feng-tao commented on a change in pull request #4287: [AIRFLOW-3479] Keeps
records in Log Table when delete DAG & refine related tests
URL: https://github.com/apache/incubator-airflow/pull/4287#discussion_r239559570
##########
File path: airflow/api/common/experimental/delete_dag.py
##########
@@ -41,6 +49,8 @@ def delete_dag(dag_id):
# noinspection PyUnresolvedReferences,PyProtectedMember
for m in models.Base._decl_class_registry.values():
if hasattr(m, "dag_id"):
+ if keep_records_in_log and m.__name__ == 'Log':
Review comment:
does it work with the log is in remote(like s3)? And will it have two
different behaviour(api vs webserver) when deleting the log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
