[
https://issues.apache.org/jira/browse/AIRFLOW-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706111#comment-16706111
]
ASF GitHub Bot commented on AIRFLOW-3426:
-----------------------------------------
feng-tao closed pull request #4259: [AIRFLOW-3426] Bugfix / Correct Python
Version Documentation Reference
URL: https://github.com/apache/incubator-airflow/pull/4259
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 5fd9bedbfe..556a5d847b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -106,7 +106,7 @@ There are three ways to setup an Apache Airflow development
environment.
1. Using tools and libraries installed directly on your system.
- Install Python (2.7.x or 3.4.x), MySQL, and libxml by using system-level
package
+ Install Python (2.7.x or 3.5.x), MySQL, and libxml by using system-level
package
managers like yum, apt-get for Linux, or Homebrew for Mac OS at first. Refer
to the [base CI
Dockerfile](https://github.com/apache/incubator-airflow-ci/blob/master/Dockerfile)
for
a comprehensive list of required packages.
@@ -267,7 +267,7 @@ meets these guidelines:
1. Preface your commit's subject & PR's title with **[AIRFLOW-XXX]** where
*XXX* is the JIRA number. We compose release notes (i.e. for Airflow releases)
from all commit titles in a release. By placing the JIRA number in the commit
title and hence in the release notes, Airflow users can look into JIRA and
Github PRs for more details about a particular change.
1. Add an [Apache License](http://www.apache.org/legal/src-headers.html)
header to all new files
1. If the pull request adds functionality, the docs should be updated as part
of the same PR. Doc string are often sufficient. Make sure to follow the
Sphinx compatible standards.
-1. The pull request should work for Python 2.7 and 3.4. If you need help
writing code that works in both Python 2 and 3, see the documentation at the
[Python-Future project](http://python-future.org) (the future package is an
Airflow requirement and should be used where possible).
+1. The pull request should work for Python 2.7 and 3.5. If you need help
writing code that works in both Python 2 and 3, see the documentation at the
[Python-Future project](http://python-future.org) (the future package is an
Airflow requirement and should be used where possible).
1. As Airflow grows as a project, we try to enforce a more consistent style
and try to follow the Python community guidelines. We track this using
[landscape.io](https://landscape.io/github/apache/incubator-airflow/), which
you can setup on your fork as well to check before you submit your PR. We
currently enforce most [PEP8](https://www.python.org/dev/peps/pep-0008/) and a
few other linting rules. It is usually a good idea to lint locally as well
using [flake8](https://flake8.readthedocs.org/en/latest/) using `flake8 airflow
tests`. `git diff upstream/master -u -- "*.py" | flake8 --diff` will return any
changed files in your branch that require linting.
1. Please read this excellent
[article](http://chris.beams.io/posts/git-commit/) on commit messages and
adhere to them. It makes the lives of those who come after you a lot easier.
diff --git a/setup.py b/setup.py
index aa80026fc9..f4d226de5b 100644
--- a/setup.py
+++ b/setup.py
@@ -399,7 +399,6 @@ def do_setup():
'Intended Audience :: System Administrators',
'License :: OSI Approved :: Apache Software License',
'Programming Language :: Python :: 2.7',
- 'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Topic :: System :: Monitoring',
],
@@ -413,7 +412,7 @@ def do_setup():
'extra_clean': CleanCommand,
'compile_assets': CompileAssets
},
- python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*',
+ python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Correct references to Python version tested (3.4 -> 3.5)
> --------------------------------------------------------
>
> Key: AIRFLOW-3426
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3426
> Project: Apache Airflow
> Issue Type: Task
> Components: Documentation
> Affects Versions: 1.9.0, 1.10.0, 1.10.1
> Environment: All
> Reporter: Bryant Biggs
> Assignee: Bryant Biggs
> Priority: Trivial
> Labels: documentation, easyfix, newbie
> Fix For: 1.10.1
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The current CI tests on Travis use Python version 2.7 and 3.5, however
> throughout the documentation there are still references to using/supporting
> 3.4. To better match what is actually supported, the 3.4 references should be
> replaced with what is actually being tested, 3.5
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
