esthernamrm commented on a change in pull request #4231: [AIRFLOW-3066] Adding
support for AWS Batch parameters
URL: https://github.com/apache/incubator-airflow/pull/4231#discussion_r237308334
##########
File path: airflow/contrib/operators/awsbatch_operator.py
##########
@@ -74,6 +79,7 @@ def __init__(self, job_name, job_definition, job_queue,
overrides, max_retries=4
self.job_definition = job_definition
self.job_queue = job_queue
self.overrides = overrides
+ self.parameters = parameters
Review comment:
Really happy this is being added! Would it make sense to name the keyword
arg `job_parameters` to better differentiate it from the `params` keyword arg?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
