[ 
https://issues.apache.org/jira/browse/AIRFLOW-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701726#comment-16701726
 ] 

ASF GitHub Bot commented on AIRFLOW-3409:
-----------------------------------------

ashb closed pull request #4248: [AIRFLOW-3409] Build docker iamge with 
'compile_assets' defined
URL: https://github.com/apache/incubator-airflow/pull/4248
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scripts/ci/kubernetes/docker/build.sh 
b/scripts/ci/kubernetes/docker/build.sh
index 49d0fb87c3..6251be717c 100755
--- a/scripts/ci/kubernetes/docker/build.sh
+++ b/scripts/ci/kubernetes/docker/build.sh
@@ -35,7 +35,7 @@ echo "Airflow directory $AIRFLOW_ROOT"
 echo "Airflow Docker directory $DIRNAME"
 
 cd $AIRFLOW_ROOT
-python setup.py sdist -q
+python setup.py compile_assets sdist -q
 echo "Copy distro $AIRFLOW_ROOT/dist/*.tar.gz ${DIRNAME}/airflow.tar.gz"
 cp $AIRFLOW_ROOT/dist/*.tar.gz ${DIRNAME}/airflow.tar.gz
 cd $DIRNAME && docker build --pull $DIRNAME --tag=${IMAGE}:${TAG}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Docker build script should build web assets (compile_assets).
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-3409
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3409
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kevin Pullin
>            Priority: Minor
>
> The docker container does not build the web assets and renders the UI 
> unusable when deployed to a local minikube k8s instance.
> A minor patch to the Dockerfile is needed to build these assets:
> -python setup.py sdist -q
> +python setup.py compile_assets sdist -q



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to