KevinYang21 edited a comment on issue #3214: [AIRFLOW-1325] Add ElasticSearch 
log handler and reader
URL: 
https://github.com/apache/incubator-airflow/pull/3214#issuecomment-442234773
 
 
   @ashb sorry somehow I lost track to this conversation. I should have 
provided more details there my bad. So the compatibility changes needed are 
basically [this 
method](https://github.com/apache/incubator-airflow/blob/master/tests/utils/log/elasticmock/fake_elasticsearch.py#L283-L295).
 It looks like the doc_type type issue has been fixed tho in [this 
commit](https://github.com/vrcmarcos/elasticmock/commit/8895aed57562f6ad7df817c352035eafc12aad60).
 I can experiment if we can just use the lib w/o modifications( maybe later 
this week or weekend).
   
   Tho this would mean we still depend on this package, is this what you 
wanted? Or you actually meant something else when saying `remove this vendored 
dep`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to