[
https://issues.apache.org/jira/browse/AIRFLOW-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693055#comment-16693055
]
ASF GitHub Bot commented on AIRFLOW-3308:
-----------------------------------------
Fokko closed pull request #4153: [AIRFLOW-3308] Fix plugins import
URL: https://github.com/apache/incubator-airflow/pull/4153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/__init__.py b/airflow/__init__.py
index 9d071a347c..d010fe4c74 100644
--- a/airflow/__init__.py
+++ b/airflow/__init__.py
@@ -79,3 +79,16 @@ class AirflowViewPlugin(BaseView):
class AirflowMacroPlugin(object):
def __init__(self, namespace):
self.namespace = namespace
+
+
+from airflow import operators # noqa: E402
+from airflow import sensors # noqa: E402
+from airflow import hooks # noqa: E402
+from airflow import executors # noqa: E402
+from airflow import macros # noqa: E402
+
+operators._integrate_plugins()
+sensors._integrate_plugins() # noqa: E402
+hooks._integrate_plugins()
+executors._integrate_plugins()
+macros._integrate_plugins()
diff --git a/airflow/operators/__init__.py b/airflow/operators/__init__.py
index 114d189da1..968b87b272 100644
--- a/airflow/operators/__init__.py
+++ b/airflow/operators/__init__.py
@@ -16,3 +16,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+
+
+def _integrate_plugins():
+ """Integrate plugins to the context"""
+ import sys
+ from airflow.plugins_manager import operators_modules
+ for operators_module in operators_modules:
+ sys.modules[operators_module.__name__] = operators_module
+ globals()[operators_module._name] = operators_module
diff --git a/airflow/sensors/__init__.py b/airflow/sensors/__init__.py
index b7f8352944..fe51779131 100644
--- a/airflow/sensors/__init__.py
+++ b/airflow/sensors/__init__.py
@@ -17,3 +17,12 @@
# specific language governing permissions and limitations
# under the License.
#
+
+
+def _integrate_plugins():
+ """Integrate plugins to the context"""
+ import sys
+ from airflow.plugins_manager import sensors_modules
+ for sensors_module in sensors_modules:
+ sys.modules[sensors_module.__name__] = sensors_module
+ globals()[sensors_module._name] = sensors_module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Plugins import is broken
> ------------------------
>
> Key: AIRFLOW-3308
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3308
> Project: Apache Airflow
> Issue Type: Bug
> Components: plugins
> Affects Versions: 2.0.0
> Reporter: John Cheng
> Assignee: John Cheng
> Priority: Major
> Fix For: 2.0.0
>
>
> #3906 removed {noformat}_integrate_plugins(){noformat} from
> {noformat}airflow.__init__{noformat} which breaks plugins import.
> {noformat}
> [2018-11-07 02:06:21,372] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/sensors/spark_submit_sensor.py
> [2018-11-07 02:06:21,376] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/sensors/__init__.py
> [2018-11-07 02:06:21,380] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/sensors/glue_sensor.py
> [2018-11-07 02:06:21,389] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/operators/postgres_operator.py
> [2018-11-07 02:06:21,393] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/operators/service_catalog_operator.py
> [2018-11-07 02:06:21,397] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/operators/glue_operator.py
> [2018-11-07 02:06:21,400] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/operators/__init__.py
> [2018-11-07 02:06:21,464] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/hooks/redis_cluster_hook.py
> [2018-11-07 02:06:21,472] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/hooks/athena_hook.py
> [2018-11-07 02:06:21,480] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/hooks/slack_hook.py
> [2018-11-07 02:06:21,486] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/hooks/__init__.py
> [2018-11-07 02:06:21,490] {{plugins_manager.py:83}} DEBUG - Importing plugin
> module /usr/local/airflow/dags/plugins/hooks/s3_hook.py
> [2018-11-07 02:06:21,497] {{plugins_manager.py:103}} DEBUG - Creating module
> airflow.operators.my_plugins
> [2018-11-07 02:06:21,498] {{plugins_manager.py:103}} DEBUG - Creating module
> airflow.sensors.my_plugins
> [2018-11-07 02:06:21,498] {{plugins_manager.py:103}} DEBUG - Creating module
> airflow.hooks.my_plugins
> [2018-11-07 02:06:21,498] {{plugins_manager.py:103}} DEBUG - Creating module
> airflow.executors.my_plugins
> [2018-11-07 02:06:21,499] {{plugins_manager.py:103}} DEBUG - Creating module
> airflow.macros.my_plugins
> [2018-11-07 02:06:54,851] {{models.py:355}} DEBUG - Importing
> /usr/local/airflow/dags/my_dag.py
> [2018-11-07 02:06:54,856] {{models.py:369}} ERROR - Failed to import:
> /usr/local/airflow/dags/my_dag.py
> Traceback (most recent call last):
> File "/usr/local/lib/python3.6/site-packages/airflow/models.py", line 366,
> in process_file
> m = imp.load_source(mod_name, filepath)
> File "/usr/local/lib/python3.6/imp.py", line 172, in load_source
> module = _load(spec)
> File "<frozen importlib._bootstrap>", line 684, in _load
> File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
> File "<frozen importlib._bootstrap_external>", line 678, in exec_module
> File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
> File "/usr/local/airflow/dags/user_profile.py", line 6, in <module>
> from airflow.hooks.my_plugins import SlackWebhookHook
> ModuleNotFoundError: No module named 'airflow.hooks.my_plugins'
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
