[ 
https://issues.apache.org/jira/browse/AIRFLOW-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684347#comment-16684347
 ] 

ASF GitHub Bot commented on AIRFLOW-2779:
-----------------------------------------

Fokko closed pull request #4177: [AIRFLOW-2779] Add project versions to LICENSE
URL: https://github.com/apache/incubator-airflow/pull/4177
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/LICENSE b/LICENSE
index 68ca6b6117..debddc0d7b 100644
--- a/LICENSE
+++ b/LICENSE
@@ -217,9 +217,9 @@ The following components are provided under the Apache 2.0 
License.
 See project link for details. The text of each license is also included
 at licenses/LICENSE-[project].txt.
 
-    (ALv2 License) hue (https://github.com/cloudera/hue/)
-    (ALv2 License) jqclock 
(https://github.com/JohnRDOrazio/jQuery-Clock-Plugin)
-    (ALv2 License) bootstrap3-typeahead 
(https://github.com/bassjobsen/Bootstrap-3-Typeahead)
+    (ALv2 License) hue v4.3.0 (https://github.com/cloudera/hue/)
+    (ALv2 License) jqclock v2.3.0 
(https://github.com/JohnRDOrazio/jQuery-Clock-Plugin)
+    (ALv2 License) bootstrap3-typeahead v4.0.2 
(https://github.com/bassjobsen/Bootstrap-3-Typeahead)
     (ALv2 License) airflow.contrib.auth.backends.github_enterprise_auth
 
 ========================================================================
@@ -229,17 +229,17 @@ MIT licenses
 The following components are provided under the MIT License. See project link 
for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-    (MIT License) jquery (https://jquery.org/license/)
-    (MIT License) dagre-d3 (https://github.com/cpettitt/dagre-d3)
-    (MIT License) bootstrap (https://github.com/twbs/bootstrap/)
-    (MIT License) d3-tip (https://github.com/Caged/d3-tip)
-    (MIT License) dataTables (https://datatables.net)
-    (MIT License) WebGL-2D (https://github.com/gameclosure/webgl-2d)
-    (MIT License) Underscorejs (http://underscorejs.org)
-    (MIT License) Bootstrap Toggle (http://www.bootstraptoggle.com)
-    (MIT License) normalize.css (http://necolas.github.io/normalize.css/)
-    (MIT License) ElasticMock (https://github.com/vrcmarcos/elasticmock)
-    (MIT License) MomentJS (http://momentjs.com/)
+    (MIT License) jquery v2.1.4 (https://jquery.org/license/)
+    (MIT License) dagre-d3 v0.6.1 (https://github.com/cpettitt/dagre-d3)
+    (MIT License) bootstrap v3.2 (https://github.com/twbs/bootstrap/)
+    (MIT License) d3-tip v0.6.3 (https://github.com/Caged/d3-tip)
+    (MIT License) dataTables v1.10.10 (https://datatables.net)
+    (MIT License) WebGL-2D (git-commit 9a7ec26) 
(https://github.com/gameclosure/webgl-2d)
+    (MIT License) Underscorejs v1.5.0 (http://underscorejs.org)
+    (MIT License) Bootstrap Toggle v2.2.0 (http://www.bootstraptoggle.com)
+    (MIT License) normalize.css v3.0.2 
(http://necolas.github.io/normalize.css/)
+    (MIT License) ElasticMock v1.3.2 (https://github.com/vrcmarcos/elasticmock)
+    (MIT License) MomentJS v2.22.2 (http://momentjs.com/)
 
 ========================================================================
 BSD 2-Clause licenses
@@ -248,7 +248,7 @@ The following components are provided under the BSD 
2-Clause license.
 See file headers and project links for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-    (BSD 2 License) flask-kerberos (https://github.com/mkomitee/flask-kerberos)
+    (BSD 2 License) flask-kerberos v1.0.4 
(https://github.com/mkomitee/flask-kerberos)
 
 ========================================================================
 BSD 3-Clause licenses
@@ -256,8 +256,8 @@ BSD 3-Clause licenses
 The following components are provided under the BSD 3-Clause license. See 
project links for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-    (BSD 3 License) Ace (https://github.com/ajaxorg/ace)
-    (BSD 3 License) d3js (https://d3js.org)
-    (BSD 3 License) parallel-coordinates 
(http://syntagmatic.github.com/parallel-coordinates/)
-    (BSD 3 License) scikit-learn (https://github.com/scikit-learn/scikit-learn)
+    (BSD 3 License) Ace v1.1.8 (https://github.com/ajaxorg/ace)
+    (BSD 3 License) d3js v3.5.17 (https://d3js.org)
+    (BSD 3 License) parallel-coordinates v0.7.0 
(http://syntagmatic.github.com/parallel-coordinates/)
+    (BSD 3 License) scikit-learn v0.19.1 
(https://github.com/scikit-learn/scikit-learn)
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Verify and correct licenses
> ---------------------------
>
>                 Key: AIRFLOW-2779
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2779
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Bolke de Bruin
>            Priority: Major
>              Labels: licenses
>             Fix For: 1.10.0
>
>
> # {color:#000000}/airflow/security/utils.py{color}
> {color:#000000}2. ./airflow/security/kerberos.py{color}
> {color:#000000}3. ./airflow/www_rbac/static/jqClock.min.js{color}
> {color:#000000}4. ./airflow/www/static/bootstrap3-typeahead.min.js{color}
> {color:#000000}5. 
> ./apache-airflow-1.10.0rc2+incubating/scripts/ci/flake8_diff.sh{color}
> {color:#000000}6. {color}[https://www.apache.org/legal/resolved.html#optional]
> {color:#000000}7. ./docs/license.rst{color}
> {color:#000000}8. airflow/contrib/auth/backends/google_auth.py{color}
> {color:#000000}9. 
> /airflow/contrib/auth/backends/github_enterprise_auth.py{color}
> {color:#000000}10. /airflow/contrib/hooks/ssh_hook.py{color}
> {color:#000000}11. /airflow/minihivecluster.py{color}
> {color:#000000}This files [1][2] seem to be 3rd party ALv2 licensed files 
> that refers to a NOTICE file, that information in that NOTICE file (at the 
> very least the copyright into) should be in your NOTICE file. This should 
> also be noted in LICENSE.{color}
>  
> {color:#000000}LICENSE is:
> - missing jQuery clock [3] and typeahead [4], as they are ALv2 it’s not 
> required to list them but it’s a good idea to do so.
> - missing the license for this [5]
> - this file [7] oddly has © 2016 GitHub, [Inc.at|http://inc.at/] the bottom 
> of it{color}
>  
>  * {color:#000000}Year in NOTICE is not correct "2016 and onwards” isn’t 
> valid as copyright has an expiry date{color}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to