brokenjacobs commented on issue #2879: [AIRFLOW-1921] Added support for presto 
https and user auth
URL: 
https://github.com/apache/incubator-airflow/pull/2879#issuecomment-437965004
 
 
   'a test'? There are no tests for presto at all in the project. By the 
project's own guidelines this hook should be moved to contrib. I'd argue it's 
mostly useless in it's current state as anyone deploying presto in production 
would have authentication enabled. I do not have the time to set up a full test 
environment inside travis for presto to get my small patch merged enabling 
authentication. If it were simply a matter of extending some existing presto 
tests, no problem. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to