phani8996 commented on a change in pull request #4111: [AIRFLOW-3266] Add AWS Athena Operator and hook URL: https://github.com/apache/incubator-airflow/pull/4111#discussion_r229656307
########## File path: airflow/contrib/operators/aws_athena_operator.py ########## @@ -0,0 +1,97 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +from airflow.models import BaseOperator +from airflow.utils.decorators import apply_defaults +from airflow.contrib.hooks.aws_athena_hook import AWSAthenaHook + + +class AWSAthenaOperator(BaseOperator): + """ + Airflow operator to run presto queries on athena. + + :param query: Presto to be run on athena. (templated) + :type query: str + :param database: Database to select. (templated) + :type database: str + :param output_location: s3 path to write the query results into. (templated) + :type output_location: str + :param aws_conn_id: aws connection to use. + :type aws_conn_id: str + """ + + ui_color = '#44b5e2' + template_fields = ('query', 'database', 'output_location') + + @apply_defaults + def __init__(self, query, database, output_location, aws_conn_id='aws_default', *args, **kwargs): + super(AWSAthenaOperator, self).__init__(*args, **kwargs) + self.query = query + self.database = database + self.output_location = output_location + self.aws_conn_id = aws_conn_id + self.client_request_token = kwargs.get('client_request_token') + self.query_execution_context = kwargs.get('query_execution_context') or {} + self.result_configuration = kwargs.get('result_configuration') or {} Review comment: Not necessarily, result_configuration and query_context have few keys which are built from other parameters like database, output_location etc.., We either have to use params passed to boto3 function(which requires user to know about above params) or with current approach user have to pass obvious parameters like database and output_location so that he don't have to worry about specifics(for beginner level users). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
