[
https://issues.apache.org/jira/browse/AIRFLOW-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667249#comment-16667249
]
ASF GitHub Bot commented on AIRFLOW-3268:
-----------------------------------------
potiuk opened a new pull request #4113: [AIRFLOW-3268] Cannot pass SSL
dictionary to mysql connection via URL
URL: https://github.com/apache/incubator-airflow/pull/4113
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3268
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
It is impossible to pass 'ssl' dictionary to MySql hook as an extrai
param via URL connection. While there is a code to pass the 'ssl'
extra query parameter, MySqldb requires this parameter to be
dictionary. When you want to create a connection via URL,
you can at most have ?ssl= url-encoded string rather than
dictionary and this is how it is passed (as string). What happens
then in MySqldb, is that all SSL parameters are ignored
and MySQL establishes a non-SSL connection silently.
This is fixed by detecting if 'ssl' is a string and converting
it to json dictionary in such case.
### Tests
- [x] My PR adds the following unit tests
TestMySqlHookConn:
test_get_conn_ssl_as_dictionary
test_get_conn_ssl_as_string
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
No new functionality
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cannot pass SSL dictionary to mysql connection via URL
> ------------------------------------------------------
>
> Key: AIRFLOW-3268
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3268
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Jarek Potiuk
> Assignee: Jarek Potiuk
> Priority: Minor
>
> It is impossible to pass 'ssl' dictionary to MySql hook as an extra param via
> URL connection. While there is a code to pass the 'ssl' extra query
> parameter, MySqldb requires this parameter to be dictionary. When you want to
> create a connection via URL you can at most have ?ssl= url-encoded string
> rather than dictionary and this is how it is passed (as string). What happens
> then in MySqldb, is that all SSL parameters are ignored and MySQL establishes
> a non-SSL connection silently. This is pretty bad.
> I am going to provide a fix soon - I will test if the 'ssl' parameter is
> string and if so, I will do json.loads() to build dictionary from the string.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
