[
https://issues.apache.org/jira/browse/AIRFLOW-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong closed AIRFLOW-3193.
-------------------------------------
Resolution: Fixed
> Pin docker requirement version
> ------------------------------
>
> Key: AIRFLOW-3193
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3193
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Guoqiang Ding
> Assignee: Guoqiang Ding
> Priority: Major
>
> The method "create_container" in APIClient of docker has been incompatible
> from version 3.0.0.
>
> Usage in `_airflow.operators.docker_operator_` as follows.
>
> {code:java}
> self.container = self.cli.create_container(
> command=self.get_command(),
> cpu_shares=cpu_shares,
> environment=self.environment,
> host_config=self.cli.create_host_config(
> binds=self.volumes,
> network_mode=self.network_mode,
> shm_size=self.shm_size,
> dns=self.dns,
> dns_search=self.dns_search),
> image=image,
> mem_limit=self.mem_limit,
> user=self.user,
> working_dir=self.working_dir
> )
> {code}
>
> The arguments such as "cpu_shares" and "mem_limit" has gone off. In other
> words, after version 3.0.0, they should be passed into `create_host_config`
> method.
>
> {quote}airflow usage code link:
> https://github.com/apache/incubator-airflow/blob/cdbdcae7c0645ac2987360fced43407202716b99/airflow/operators/docker_operator.py#L207
> {quote}
>
> {quote}version 3.0.0 code link:
> https://github.com/docker/docker-py/blob/91bc75cc92f578ae9d659ad7e8ed11a0877b70aa/docker/api/container.py#L206
> {quote}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
