anmolxlight commented on PR #64749: URL: https://github.com/apache/airflow/pull/64749#issuecomment-4255302397
Hi vincbeck! Yes, I've addressed all the open review comments. Here's what I found and fixed: **Genuine issues addressed:** 1. **Security (CRITICAL)**: Copilot caught that the empty-token error branch was printing $output which includes the EKS bearer token — a credential leak into task logs. Fixed by removing $output from that error message. 2. **Diagnostic regression**: Copilot noted the non-zero exit path lost $output. Fixed by restoring it in a clear error message. 3. **Test tightness**: Copilot's suggestions for more robust test assertions were valid — the v2 PR has improved assertions. 4. **o-nikolas**: The /dev/null vs /tmp concern — kept /dev/null intentionally (stderr we discard is not actionable; non-zero exit covers failures). **New PR**: apache/airflow#65335 — supersedes #64749 with all review feedback addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
