nailo2c commented on PR #63901: URL: https://github.com/apache/airflow/pull/63901#issuecomment-4167070522
It's a really great suggestion! This not only reduces the amount of code but also prevents drift issues (e.g. I found that `build-docs` added a new flag `--clean-inventory-cache` in #63630, and my previous version obviously didn't cover that). Many thanks-- I learned a lot! The new version derives the reproduction command directly from the live Click context via a single generic function `build_reproduction_command_from_context`, so Click remains the single source of truth for command names and flags. Adding reproduction support to any future breeze command now only requires `@click.pass_context` and a one-liner call. <details> <summary>Some screenshots of the current version's output</summary> + core-tests <img width="1892" height="523" alt="refactor_core_test" src="https://github.com/user-attachments/assets/96a676e1-d126-41db-8be1-5ce6c867eb99"; /> + provider-tests <img width="2158" height="937" alt="refactor_provider" src="https://github.com/user-attachments/assets/78e5a997-ecb4-4d18-a13f-2abcc8a55b6c"; /> + build-docs <img width="1106" height="718" alt="refactor_build_docs_only" src="https://github.com/user-attachments/assets/28584a54-6f13-410a-93c0-36b6e5e39949"; /> </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
