haseebmalik18 commented on code in PR #64191:
URL: https://github.com/apache/airflow/pull/64191#discussion_r3005407324
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
@@ -61,9 +61,11 @@ export class XComsPage extends BasePage {
}
public async navigate(): Promise<void> {
- await this.navigateTo(XComsPage.xcomsUrl);
- await this.page.waitForURL(/.*xcoms/, { timeout: 15_000 });
- await this.xcomsTable.waitFor({ state: "visible", timeout: 10_000 });
+ await expect(async () => {
+ await this.navigateTo(XComsPage.xcomsUrl);
+ await expect(this.page).toHaveURL(/.*xcoms/, { timeout: 15_000 });
+ }).toPass({ intervals: [2000], timeout: 60_000 });
+ await expect(this.xcomsTable).toBeVisible({ timeout: 10_000 });
await this.page.waitForLoadState("networkidle");
Review Comment:
I think maybe networkidle wait can be removed here? the toBeVisible
assertion above already waits for the UI state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
