imrichardwu commented on code in PR #62583: URL: https://github.com/apache/airflow/pull/62583#discussion_r2982079553
########## airflow-core/src/airflow/migrations/versions/0110_3_2_0_add_met_to_deadline.py: ########## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Add met column to deadline table. + +Revision ID: 7f3a2b1e9c4d +Revises: 1d6611b6ab7c +Create Date: 2026-03-20 14:23:07.842153 + +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op + +# revision identifiers, used by Alembic. +revision = "7f3a2b1e9c4d" +down_revision = "1d6611b6ab7c" +branch_labels = None +depends_on = None +airflow_version = "3.2.0" + + +def upgrade(): + """Add met boolean column to deadline table.""" + with op.batch_alter_table("deadline", schema=None) as batch_op: + batch_op.add_column(sa.Column("met", sa.Boolean(), nullable=False, server_default=sa.false())) + + +def downgrade(): + """Remove met column from deadline table.""" + with op.batch_alter_table("deadline", schema=None) as batch_op: + batch_op.drop_column("met") Review Comment: I added the met column to be used in my api, but I will wait on your response about the prune first before making another, since if we decide to keep the original prune and just show "upcoming" and "missed" in the Dag Run UI, then this won't be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
