DonHaul opened a new issue, #63996:
URL: https://github.com/apache/airflow/issues/63996

   ### What do you see as an issue?
   
   In 
https://airflow.apache.org/docs/apache-airflow/stable/best-practices.html#mocking-variables-and-connections
 
   we see the following line of code
   ```
   Connection.get_connection_from_secrets("my_conn").login
   ```
   This referes to the [connection in 
`airflow.models`](https://github.com/apache/airflow/blob/3.1.8/airflow-core/src/airflow/models/connection.py)
 which from what I understood will be deprecated in favor of 
[`airflow.sdk.Connection`](https://github.com/apache/airflow/blob/3.1.8/task-sdk/src/airflow/sdk/definitions/connection.py)
  , which does not have definition for `get_connection_from_secrets()` making 
the documentation also not up to the standard.
   
   
   ### Solving the problem
   
   Give an example using the `airflow.sdk.Connection`
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to