sidshas03 commented on PR #63355: URL: https://github.com/apache/airflow/pull/63355#issuecomment-4089442331
> Once those changes are addressed, happy to approve and merge @kaxil @cedric-fauth I’ve pushed the follow-up changes from the latest review round. I have changed the followings: - Removed the `hasattr(..., "value")` guards and simplified state comparison. - Updated the 409 response description to clearly differ from the idempotent 200 case. - Added a code comment clarifying that the idempotency check is only for duplicate terminal-state updates. - Added an explicit terminal mismatch test: TI already `SUCCESS`, request `FAILED` -> `409 invalid_state`. Validation: - `pytest -q airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py -k "ti_update_state_same_state_is_idempotent or ti_update_state_not_running or ti_update_state_terminal_state_mismatch_returns_conflict"` Please re-review when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
