eladkal commented on code in PR #62962:
URL: https://github.com/apache/airflow/pull/62962#discussion_r2942514718
##########
providers/amazon/pyproject.toml:
##########
@@ -76,7 +76,7 @@ dependencies = [
"PyAthena>=3.10.0",
"jmespath>=0.7.0",
# Do not change sagemaker-studio versions without approval from AWS.
- "sagemaker-studio>=1.0.9",
+ "sagemaker-studio>=1.0.25,<1.1.0",
# Sagemaker studio in Python 3.13 requires version >=1.1.0 and Pydynamodb
>=0.7.5
"pydynamodb>=0.8.1; python_version >= '3.13'",
Review Comment:
This should be removed as no longer needed
##########
providers/amazon/pyproject.toml:
##########
@@ -76,7 +76,7 @@ dependencies = [
"PyAthena>=3.10.0",
"jmespath>=0.7.0",
# Do not change sagemaker-studio versions without approval from AWS.
- "sagemaker-studio>=1.0.9",
+ "sagemaker-studio>=1.0.25,<1.1.0",
Review Comment:
There should be a comment explaining the reasoning for the limit of <1.1.0
and explnation how the airflow can track it's progress given that the upstream
library is not open sourced.
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/sagemaker_unified_studio.py:
##########
@@ -101,6 +101,20 @@ class SageMakerNotebookOperator(BaseOperator):
"""
operator_extra_links = (SageMakerUnifiedStudioLink(),)
+ # These fields are declared as template_fields so Airflow resolves XCom
references
+ # (e.g. task_instance.xcom_pull(...)) to actual string values before
execute() is called.
+ # Without this, the hook would be instantiated with unresolved
PlainXComArg objects,
+ # causing a ParamValidationError when the underlying SDK tries to use them
as strings.
Review Comment:
There is no need for this comment. This is known to airflow developers
##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio.py:
##########
@@ -124,9 +131,35 @@ def mock_mwaa_environment(parameters: dict):
setup_mwaa_environment =
mock_mwaa_environment(mock_mwaa_environment_params)
- # [START howto_operator_sagemaker_unified_studio_notebook]
notebook_path = "test_notebook.ipynb" # This should be the path to your
.ipynb, .sqlnb, or .vetl file in your project.
+ # [START howto_operator_sagemaker_unified_studio_notebook_explicit_params]
Review Comment:
The `howto_operator_sagemaker_unified_studio_notebook_explicit_params`
marker is not refrenced anywhere in the docs. Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
