potiuk commented on PR #63663: URL: https://github.com/apache/airflow/pull/63663#issuecomment-4066419626
Converted to Draft, but I fail to see why you would like to not commit this message if session is provided from outside - that makes very little sense because the idea is that those methods actually commit the change - even if it means that they commit other things that were changed before. Do you have a good reason for that change or is it just generic thinking that it should be like that ? Is there a problem you are trying to solve ? Because it's far from refactoring. This is changing semantics of those methods. Did you evaluate what effects it has on all the places where those methods are used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
