ronaldorcampos commented on code in PR #62044:
URL: https://github.com/apache/airflow/pull/62044#discussion_r2938586066
##########
airflow-core/src/airflow/models/connection.py:
##########
@@ -252,9 +252,10 @@ def _parse_from_uri(self, uri: str):
else:
for key, value in query.items():
try:
- query[key] = json.loads(value)
- except (JSONDecodeError, TypeError):
- self.log.info("Failed parsing the json for key %s",
key)
+ if value:
Review Comment:
Valid points. Would empty values be worth being parsed though? I mean, it
seems pointless and no empty values would be intentionally be passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
