YoannAbriel opened a new pull request, #63628:
URL: https://github.com/apache/airflow/pull/63628
Migration 0094 (`replace_deadline_inline_callback_with_fkey`) processes
every deadline row through Python's `serde.deserialize()` during upgrade,
instantiating Python objects for each row. At scale (10M rows), this takes ~33
minutes.
The callback JSON format prior to 3.2.0 is predictable (always
`AsyncCallback` with a fixed serde wrapper structure), so the transformation
can be done entirely in SQL.
**PostgreSQL:** single writable CTE with `gen_random_uuid()` and
`jsonb_build_object()` — handles INSERT into `callback` and UPDATE of
`deadline` in one statement. No Python loop, no batching.
**MySQL/SQLite:** batched approach with Python UUID generation but direct
JSON dict access instead of `serde.deserialize()` round-trip.
Also removes runtime module imports (`airflow.serialization.serde`,
`airflow.models.callback`, `airflow.models.deadline`) from the upgrade path,
hardcoding constant values instead.
Closes: #63532
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4, claude-opus-4-6)
Generated-by: Claude Code (Opus 4, claude-opus-4-6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
