eladkal commented on code in PR #62852:
URL: https://github.com/apache/airflow/pull/62852#discussion_r2901657769
##########
providers/salesforce/tests/unit/salesforce/operators/test_bulk.py:
##########
@@ -204,6 +204,13 @@ def test_execute_salesforce_bulk_delete(self,
mock_get_conn):
use_serial=use_serial,
)
+ def test_template_fields(self):
+ """
+ Test that template_fields contains the expected fields
+ """
+ expected_fields = ("payload", "object_name", "operation",
"external_id_field", "salesforce_conn_id")
+ assert SalesforceBulkOperator.template_fields == expected_fields
Review Comment:
This test has little value.
It doesn't verify templating actually worked.
You should add a test that given
`payload=" {{ ds }} "` it will render to the templated value.
There are probably some examples for this in other templating tests in the
code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
