cetingokhan commented on code in PR #62816: URL: https://github.com/apache/airflow/pull/62816#discussion_r2900129133
########## providers/common/ai/tests/unit/common/ai/hooks/test_pydantic_ai.py: ########## @@ -16,13 +16,20 @@ # under the License. from __future__ import annotations +import json +import sys from unittest.mock import MagicMock, patch import pytest from pydantic_ai.models import Model from airflow.models.connection import Connection -from airflow.providers.common.ai.hooks.pydantic_ai import PydanticAIHook +from airflow.providers.common.ai.hooks.pydantic_ai import ( + PydanticAIAzureHook, + PydanticAIBedrockHook, + PydanticAIHook, Review Comment: You're absolutely right. Since the previous review suggested that subclasses might not need their own default_conn_name, I had revised them to share the base class's default. I added those tests specifically to verify that sharing was working as intended. However, I see your point regarding the conn_type mismatch and the confusion it creates. I've now separated the default_conn_name for each subclass again and updated the tests to match. Thanks for catching that! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
