XD-DENG commented on code in PR #62975: URL: https://github.com/apache/airflow/pull/62975#discussion_r2896745775
########## .github/workflows/check-newsfragment-pr-number.yml: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +name: Check newsfragment PR number +on: # yamllint disable-line rule:truthy + pull_request: + branches: + - main + - v[0-9]+-[0-9]+-test + - v[0-9]+-[0-9]+-stable + - providers-[a-z]+-?[a-z]*/v[0-9]+-[0-9]+ + types: [opened, reopened, synchronize] + +permissions: + contents: read + pull-requests: read + +concurrency: + group: check-newsfragment-${{ github.event.pull_request.number }} + cancel-in-progress: true + +jobs: + check-newsfragment-pr-number: + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - name: Check newsfragment PR number + env: + GH_TOKEN: ${{ github.token }} + PR_NUMBER: "${{ github.event.pull_request.number }}" + run: | + # Find newsfragment files whose PR number doesn't match this PR. + # Use the REST API to get file statuses so we can exclude deleted files. + bad=$(gh api "repos/${{ github.repository }}/pulls/${PR_NUMBER}/files" \ + --paginate --jq '.[] | select(.status != "removed") | .filename' \ + | grep '/newsfragments/.*\.rst$' \ + | grep -v "/newsfragments/${PR_NUMBER}\." || true) + + if [ -n "$bad" ]; then + echo "::error::Newsfragment PR number mismatch. Expected ${PR_NUMBER} but found: ${bad}" Review Comment: Oh, that's a good point. I actually didn't notice it's mentioned here in the pull request template. What would you suggest? Updating the PR template or try to somehow enhance this new action workflow (then it has to have a way to automatically find the issue the PR is trying to address)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
