Dev-iL opened a new pull request, #62999:
URL: https://github.com/apache/airflow/pull/62999
## Summary
- Fix `task_instance_mutation_hook` receiving `run_id=None` during
TaskInstance creation
- Add regression test verifying the hook sees the correct `run_id`
## Root Cause
In `airflow/models/taskinstance.py`, `TI.__init__()` calls
`self.refresh_from_task(task)` which invokes
`task_instance_mutation_hook(task_instance)` via `_refresh_from_task()`.
However, `self.run_id` is not assigned until **after** this call, so any
mutation hook that depends on `run_id` sees `None`.
```python
# Before (buggy order in TI.__init__):
self.refresh_from_task(task) # calls hook — self.run_id is None here
...
self.run_id = run_id # too late
```
This means a hook like the one in the issue:
```python
def task_instance_mutation_hook(task_instance):
if task_instance.run_id.startswith("manual__"):
task_instance.pool = "manual_pool"
```
fails with `AttributeError: 'NoneType' object has no attribute 'startswith'`
(or silently does nothing if guarded with `getattr`).
## Fix
Move `self.run_id = run_id` before `self.refresh_from_task(task)` in
`TI.__init__()`:
```python
# After (fixed):
self.run_id = run_id # set BEFORE refresh_from_task
self.map_index = map_index
self.refresh_from_task(task) # hook now sees correct run_id
```
The later `self.run_id = run_id` assignment is kept because the deprecated
`execution_date` code path may resolve `run_id` from a database lookup and
needs to overwrite the initial value.
## Test Plan
- [x] Added `test_task_instance_mutation_hook_has_run_id` in
`tests/models/test_dagrun.py` that verifies the mutation hook receives a TI
with `run_id` set (not `None`) during `create_dagrun()` / `verify_integrity()`
closes: #61945
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.6 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
