potiuk commented on code in PR #62924:
URL: https://github.com/apache/airflow/pull/62924#discussion_r2892457985
##########
providers/fab/pyproject.toml:
##########
@@ -68,27 +69,28 @@ dependencies = [
"apache-airflow-providers-common-compat>=1.12.0",
# Blinker use for signals in Flask, this is an optional dependency in
Flask 2.2 and lower.
# In Flask 2.3 it becomes a mandatory dependency, and flask signals are
always available.
- "blinker>=1.6.2; python_version < '3.13'",
+ "blinker>=1.6.2",
# Flask 2.3 is scheduled to introduce a number of deprecation removals -
some of them might be breaking
# for our dependencies - notably `_app_ctx_stack` and `_request_ctx_stack`
removals.
# We should remove the limitation after 2.3 is released and our
dependencies are updated to handle it
- "flask>=2.2.1,<2.3; python_version < '3.13'",
+ "flask>=2.2.1,<2.3",
# We are tightly coupled with FAB version as we vendored-in part of FAB
code related to security manager
# This is done as part of preparation to removing FAB as dependency, but
we are not ready for it yet
# Every time we update FAB version here, please make sure that you review
the classes and models in
# `airflow/providers/fab/auth_manager/security_manager/override.py` with
their upstream counterparts.
# In particular, make sure any breaking changes, for example any new
methods, are accounted for.
"flask-appbuilder==5.0.1; python_version < '3.13'",
- "flask-login>=0.6.2; python_version < '3.13'",
- "flask-session>=0.8.0; python_version < '3.13'",
- "msgpack>=1.0.0; python_version < '3.13'",
- "flask-sqlalchemy>=3.0.5; python_version < '3.13'",
- "flask-wtf>=1.1.0; python_version < '3.13'",
- "connexion[flask]>=2.14.2,<3.0; python_version < '3.13'",
- "jmespath>=0.7.0; python_version < '3.13'",
- "werkzeug>=2.2,<4; python_version < '3.13'",
- "wtforms>=3.0,<4; python_version < '3.13'",
- "cachetools>=6.0; python_version < '3.13'",
+ "flask-appbuilder>=5.2.0; python_version >= '3.13'",
Review Comment:
We cannot do that. See the comment above. We need to upgrade to FAB provider
5.2.0 and keep `==` - each fab provider is tightly coupled with single versio
of FAB, because (and it was not my decision, I think it was pretty bad
decision) we vendor-in part of FAB that we link with - the override.py.
In order to upgrade to 5.2.0 we need to check the differences that were
implemented in security manager in FAB between version 5.0.1 and 5.2.0 and
apply it to our "override.py"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
