jscheffl commented on code in PR #62896:
URL: https://github.com/apache/airflow/pull/62896#discussion_r2892203027
##########
providers/edge3/src/airflow/providers/edge3/worker_api/datamodels.py:
##########
@@ -200,3 +200,10 @@ class WorkerSetStateReturn(BaseModel):
str | None,
Field(description="Comments about the maintenance state of the
worker."),
] = None
+ concurrency: Annotated[
Review Comment:
If we extend the response by another field - not being an expert in
FastAPI/Pydantic - what happens if we have an running EdgeWorker < 3.2.0 and
you upgrade central deployment. Will the "new" response on heartbeat be
accepted or will it raise an error? Have you tested this a backwards-compat?
##########
providers/edge3/src/airflow/providers/edge3/models/db.py:
##########
@@ -31,6 +31,7 @@
_REVISION_HEADS_MAP: dict[str, str] = {
"3.0.0": "9d34dfc2de06",
+ "3.1.0": "b3c4d5e6f7a8",
Review Comment:
3.1.0 is already released, need to assume it gets to be 3.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
