kaxil commented on code in PR #62898: URL: https://github.com/apache/airflow/pull/62898#discussion_r2892197028
########## providers/common/ai/src/airflow/providers/common/ai/mixins/approval.py: ########## @@ -0,0 +1,186 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging +from datetime import timedelta +from typing import TYPE_CHECKING, Any, Protocol + +from pydantic import BaseModel + +from airflow.providers.common.compat.sdk import AirflowException + +log = logging.getLogger(__name__) + +if TYPE_CHECKING: + from airflow.sdk import Context + + +class ApprovalFailedException(AirflowException): + """Failed to approve.""" + + +class ApprovalRejectionException(AirflowException): + """Rejected by the reviewer.""" + + +class DeferForApprovalProtocol(Protocol): + """Protocol for defer for approval mixin.""" + + approval_timeout: timedelta | None + allow_modifications: bool + prompt: str + task_id: str + defer: Any + + +class LLMApprovalMixin: + """ + Mixin that pauses an operator for human review before returning output. + + When ``require_approval=True`` on the operator, the generated output is + presented to a human reviewer via the Airflow Human-in-the-Loop (HITL) + interface. The task defers until the reviewer approves or rejects. + + If ``allow_modifications=True``, the reviewer can also edit the output + before approving. The (possibly modified) output is then returned as the + task result. + + Operators that use this mixin must set the following attributes: + + - ``require_approval`` (``bool``) + - ``allow_modifications`` (``bool``) + - ``approval_timeout`` (``timedelta | None``) + - ``prompt`` (``str``) + """ + + APPROVE = "Approve" + REJECT = "Reject" + + def defer_for_approval( + self: DeferForApprovalProtocol, + context: Context, + output: Any, + *, + subject: str | None = None, + body: str | None = None, + ) -> None: + """ + Write HITL detail, then defer to HITLTrigger for human review. + + :param context: Airflow task context. + :param output: The generated output to present for review. + :param subject: Headline shown on the Required Actions page. + Defaults to ``"Review output for task `<task_id>`"``. + :param body: Markdown body shown below the headline. + Defaults to the prompt and output wrapped in a code block. + """ + from airflow.providers.standard.triggers.hitl import HITLTrigger + from airflow.sdk.execution_time.hitl import upsert_hitl_detail + from airflow.sdk.timezone import utcnow + + if isinstance(output, BaseModel): + output = output.model_dump() + else: + # Always make string output so that when comparing in the execute_complete matches + output = str(output) + + ti_id = context["task_instance"].id + timeout_datetime = utcnow() + self.approval_timeout if self.approval_timeout else None + + if subject is None: + subject = f"Review output for task `{self.task_id}`" + + if body is None: + body = f"```\nPrompt: {self.prompt}\n\n{output}\n```" + + hitl_params: dict[str, dict[str, Any]] = {} + if self.allow_modifications: + hitl_params = { + "output": { + "value": output, + "description": "Edit the output before approving (optional).", + "schema": {"type": "string"}, + }, + } + + upsert_hitl_detail( + ti_id=ti_id, + options=[LLMApprovalMixin.APPROVE, LLMApprovalMixin.REJECT], + subject=subject, + body=body, + defaults=None, Review Comment: +1, `None` is the right call here. `defaults` controls both the pre-selected option in the UI and the auto-selected option on timeout. For LLM-generated content that a human explicitly opted into reviewing (`require_approval=True`), auto-approving on timeout would defeat the purpose. With `defaults=None`, a timeout raises `AirflowTaskTimeout` instead of silently accepting the output. Much safer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
