YoannAbriel opened a new pull request, #62931:
URL: https://github.com/apache/airflow/pull/62931

   ## Problem
   
   `use_job_schedule=False` disables both time-based and asset-based 
scheduling. The config is documented as only affecting cron interval 
scheduling, but asset-triggered DAGs also stop getting scheduled.
   
   ## Root Cause
   
   In `SchedulerJobRunner._do_scheduling_loop`, the entire 
`_create_dagruns_for_dags` call is gated behind `use_job_schedule`. That method 
handles both time-based *and* asset-triggered dag run creation, so setting the 
flag to `False` skips everything.
   
   ## Fix
   
   Moved the `use_job_schedule` check inside `_create_dagruns_for_dags` so it 
only gates `_create_dag_runs` (time-based). Asset-triggered and partitioned 
asset dag runs are always processed regardless of the setting.
   
   Added two tests verifying that with `use_job_schedule=False`:
   - Asset-triggered dag runs are still created
   - Time-based dag runs are not created
   
   Closes: #62929
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to