YoannAbriel opened a new pull request, #62926:
URL: https://github.com/apache/airflow/pull/62926
## Problem
`DataprocCreateBatchOperator.__update_batch_labels()` replaces dots and
spaces with underscores when building GCP labels from DAG/task IDs. GCP labels
only allow lowercase letters, numbers, and dashes — underscores are invalid.
This causes `InvalidArgument` errors when task IDs contain underscores (common
with task groups, e.g. `process_data`).
## Root Cause
`re.sub(r"[.\s]", "_", ...)` only strips dots and whitespace, converting
them to underscores. Any existing underscores in the ID pass through unchanged.
The validation regex `r"^[a-z][\w-]{0,62}$"` also incorrectly allows
underscores via `\w`.
Additionally, the `dag_display_name` validation was checking `dag_id`
instead of the actual `dag_display_name` value.
## Fix
- Replace the substitution pattern with `re.sub(r"[^a-z0-9-]", "-", ...)` —
strips everything except valid label characters
- Update the validation regex to `r"^[a-z0-9][a-z0-9-]{0,62}$"` matching
GCP's actual requirements
- Fix the `dag_display_name` validation to check the right variable
- Added test for underscore/dot sanitization
Closes: #59332
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
