gopidesupavan commented on code in PR #62901: URL: https://github.com/apache/airflow/pull/62901#discussion_r2888661745
########## providers/common/ai/src/airflow/providers/common/ai/toolsets/logging.py: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Logging wrapper toolset for pydantic-ai tool calls.""" + +from __future__ import annotations + +import json +import logging +import time +from dataclasses import dataclass, field +from typing import TYPE_CHECKING, Any + +from pydantic_ai.toolsets.wrapper import WrapperToolset + +if TYPE_CHECKING: + from pydantic_ai.toolsets.abstract import ToolsetTool + + from airflow.sdk.types import Logger + + +@dataclass +class LoggingToolset(WrapperToolset[Any]): + """Wrap a toolset to log each tool call with timing.""" + + logger: Logger | logging.Logger = field(default_factory=lambda: logging.getLogger(__name__)) + + async def call_tool( + self, + name: str, + tool_args: dict[str, Any], + ctx: Any, + tool: ToolsetTool[Any], + ) -> Any: + self.logger.info("::group::Tool call: %s", name) + if tool_args: + self.logger.debug("Tool args: %s", json.dumps(tool_args, default=str)) Review Comment: Should we document this pottential PII/PCI data can also log here what pydantic-ai logs between tool calls? For example, if the LLM generates a query with PII or PCI data in a WHERE clause equality check, that could end up in the logs. Not sure may be a flag driven approach ? there is one library microsoft `presidio_analyzer` it analyzes https://github.com/microsoft/presidio/tree/main could be nice addition in this space . can separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
