Subham-KRLX commented on code in PR #62905:
URL: https://github.com/apache/airflow/pull/62905#discussion_r2887313420
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -534,6 +536,28 @@ def add_docker_in_docker(self, compose_file_list:
list[Path]):
# the /var/run/docker.sock is available. See
https://github.com/docker/for-mac/issues/6545
compose_file_list.append(SCRIPTS_CI_DOCKER_COMPOSE_DOCKER_SOCKET_PATH)
Review Comment:
Thanks @kaxil All addressed renamed to
[get_main_git_dir_for_worktree()](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)
returning the main
[.git](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)
dir directly (no more duplicated
[.parent.parent](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)),
added relative path resolution, quoted YAML values, and added 8 unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
