dejii commented on code in PR #54101:
URL: https://github.com/apache/airflow/pull/54101#discussion_r2887223111
##########
providers/google/src/airflow/providers/google/cloud/triggers/cloud_storage_transfer_service.py:
##########
@@ -112,6 +109,11 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
yield TriggerEvent({"status": "error", "message": str(ex)})
return
+ if not all_operations_found:
+ self.log.info("Not all transfer jobs have associated
operations yet. Waiting.")
+ await asyncio.sleep(self.poll_interval)
+ continue
Review Comment:
This is already covered by the tests added in the PR:
`test_run_wait_for_job_with_no_initial_operation` - tests the case where one
job has no operation initially (None), then the trigger retries and eventually
succeeds.
`test_run_continues_polling_if_no_operation` - tests the case where all jobs
have no operation (None, None), triggering the `all_operations_found=False`
path and continued polling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
