anishgirianish commented on PR #62343:
URL: https://github.com/apache/airflow/pull/62343#issuecomment-4001226267
> Hi @anishgirianish, thank you for the update.
>
> However, the main problem mentioned in the last review has not yet been
resolved. We’re still mixing the `executor` field from the Test Connection API
with the `team_name` field in Executor.
>
> Additionally, after the last fix, the `queue` semantics mentioned in the
dev list are missing from the current PR.
>
> Could you please revise the semantics of `executor`, `team_name`, and
`queue` when you have time? Thanks!
Hi @jason810496 Thank you so much for the re-review. Addressed all review
feedback:
- Executor matching uses executor.name.alias/module_path instead of
team_name
- Restored queue field (model, migration, API, workload)
- Moved supports_connection_test guard into trigger_connection_tests()
- Defined ACTIVE_STATES frozenset, used in scheduler
Would like to request you for your re-review thanks.
E2e verified via Breeze (screencast attached): async test flow +
save-and-test with revert-on-failure both working.
https://github.com/user-attachments/assets/a2c2396e-e1be-4803-be77-7a1f9c3c6662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
