Lee-W commented on code in PR #62737:
URL: https://github.com/apache/airflow/pull/62737#discussion_r2878238579
##########
providers/fab/tests/unit/fab/auth_manager/security_manager/test_override.py:
##########
@@ -32,6 +34,46 @@ def __init__(self):
class TestFabAirflowSecurityManagerOverride:
+
@mock.patch("airflow.providers.fab.auth_manager.security_manager.override.log")
+ def
test_add_permission_to_role_ignores_duplicate_from_concurrent_worker(self,
mock_log):
+ sm = EmptySecurityManager()
+ role = Mock(id=1, name="test_admin", permissions=[])
+ permission = Mock(id=2)
+
+ mock_session = Mock()
+ mock_session.commit.side_effect = IntegrityError("stmt", {},
Exception("Duplicate entry"))
+
+ sm._is_permission_assigned_to_role = Mock(return_value=True)
+
+ with mock.patch.object(EmptySecurityManager, "session", mock_session):
+ sm.add_permission_to_role(role, permission)
+
+ mock_session.rollback.assert_called_once_with()
+ sm._is_permission_assigned_to_role.assert_called_once_with(role_id=1,
permission_view_id=2)
+ mock_log.error.assert_not_called()
Review Comment:
```suggestion
assert mock_session.rollback.mock_calls == [call()]
sm._is_permission_assigned_to_role.mock_calls[call(role_id=1,
permission_view_id=2)]
mock_log.error.mock_calls == []
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
