dheerajturaga commented on PR #61155: URL: https://github.com/apache/airflow/pull/61155#issuecomment-3924554812
> Approving to unblock. > > Some small sanity questions, please check prior merge. > > One nit on pytest, please add another small assert. > > One question: How does alembic behave if the three tables exist before and the version table is missing? Will just the version table be added and the rest be kept? (Just did one test, started this PR from a existing setup of main, that was good. Also starting with empty DB was working) You're safe. op.create_table() calls use if_not_exists=True , So the behavior when tables exist but the version table is missing: 1. Alembic creates alembic_version_edge3 2. Runs the migration - all CREATE TABLE IF NOT EXISTS statements silently no-op on the existing tables 3. Records revision 9d34dfc2de06 in the version table 4. Done, existing data is untouched This is exactly the scenario EdgeExecutor.start() handles: first boot with tables already present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
