nailo2c commented on PR #61048:
URL: https://github.com/apache/airflow/pull/61048#issuecomment-3863076559

   Hi @shahar1, sure :) but let me confirm the system tests are 
[example_azure_blob_to_gcs.py](providers/google/tests/system/google/cloud/azure/example_azure_blob_to_gcs.py)
 and 
[example_azure_fileshare_to_gcs.py](https://github.com/apache/airflow/blob/main/providers/google/tests/system/google/cloud/azure/example_azure_fileshare_to_gcs.py),
 right?
   
   If so, here are the results:
   
   # example_azure_blob_to_gcs.py
   
   + It works well on Airflow (the first two failures were due to my 
environment misconfigurations, not code issues).
   
   <img width="2555" height="608" alt="example_azure_blob_to_gcs_1_airflow" 
src="https://github.com/user-attachments/assets/77c49902-6f0d-4fee-8b5c-2627434baba6";
 />
   
   + It reads the file from Azure Blob Storage and transfers it to GCS 
successfully.
   
   <img width="2545" height="1144" alt="example_azure_blob_to_gcs_2_azure" 
src="https://github.com/user-attachments/assets/01b9d962-a11b-45db-b1b5-285baa1a1b57";
 />
   <img width="2549" height="538" alt="example_azure_blob_to_gcs_3_gcp" 
src="https://github.com/user-attachments/assets/5f0e9593-079b-4942-a939-59303924b759";
 />
   
   + It's not a breaking change-- when `unwrap_single` is not set, it returns a 
string as before.
   
   <img width="2013" height="399" 
alt="example_azure_blob_to_gcs_4_old_return_str" 
src="https://github.com/user-attachments/assets/e0da9b55-9400-4142-a2ca-bdd86346b8d8";
 />
   
   + After setting `unwrap_single=False`, it returns a list of URIs.
   
   <img width="2017" height="426" 
alt="example_azure_blob_to_gcs_5_new_return_list" 
src="https://github.com/user-attachments/assets/dee6c181-2726-43c5-bb14-3471f4b5a100";
 />
   
   # example_azure_fileshare_to_gcs.py
   
   + Same for `example_azure_fileshare_to_gcs.py`
   
   <img width="2550" height="1351" alt="sync_azure_files_with_gcs" 
src="https://github.com/user-attachments/assets/64a1dbe2-c8ae-4a25-b5c8-490c5014ddcc";
 />
   
   ---
   
   Please let me know if there's anything else I can help with :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to