dstandish commented on PR #61420:
URL: https://github.com/apache/airflow/pull/61420#issuecomment-3846886228
ok so re your comment, re line 173
just thinking it through .... i looked and ....
current logical date would be from the run id you supplied when calling
it _appears_ current_logical_date is a logical date but, does it matter if
the run id passed here is a manual run? _(in which case the logical date might
be not driven by the timetable)_.
i'm just not sure that it really matters in any circumstance
so the scenario here is like, manual run, and getting the future (or past)
runs relative to that manual (non-aligned) run right?
basicallly where the rubber meets the road here is this block
```
dates = [
info.logical_date
for info in dag.iter_dagrun_infos_between(start_date, end_date)
if info.logical_date # todo: AIP-76 this will not find anything
where logical date is null
]
run_ids = [dr.run_id for dr in DagRun.find(dag_id=dag.dag_id,
logical_date=dates, session=session)][3:22 AM]i ```
**am not sure why we even bother to iter the run infos. why do we not just
query based on date range**
we iter the run infos to identify dates.
then we perform lookup for those specific dates.
**why not just query all the runs in the range?**
i feel like if we made that change (just query the runs) no one would ever
notice or care
and if anyone ever did notice or care, their feelings would probably be
positive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
