bugraoz93 commented on PR #42782: URL: https://github.com/apache/airflow/pull/42782#issuecomment-2414600611
> Merging because we need that for other PRs. (dynamic order_by). > > We can adjust with following PR if needed. Make sense! I don't want to block anyone in the development flow. At least, you have already driven it and finalised the work so that it didn't block anyone for a long time. For sure, I don't have any comments on the SortParam part. It looks great. I think one of the methods (`get_primary_key_of_given_model_string`) of the SortParam hasn't been used anywhere since the bespoke part was removed. I will remove the unused method in my next MR. I have started working on the next one PATCH a Connection already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
