ArshiaZr opened a new pull request, #43018:
URL: https://github.com/apache/airflow/pull/43018
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #42881
related: #42881
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
### Pull Request Description
**Summary:**
This PR introduces the `get_name` method as an abstract method in the base
metrics logger class. The `get_name` method has been implemented in both the
StatsD and OTel metrics logger classes to handle metric name construction
consistently across backends.
**Note:** The PR is not fully finished and it does not close #42881. I'm
sending it to PR to see if I can proceed and finish it. The `get_name` method
has been integrated into the `incr` method of the StatsD logger, but I have not
applied it to other methods yet. I'm doing this to verify whether it aligns
with the proposed functionality before further updates.
**Changes:**
- Added the `get_name` abstract method to the base metrics logger interface.
- Implemented the `get_name` method in the StatsD logger class to
concatenate tags with the metric name.
- Implemented the `get_name` method in the OTel logger class to return the
metric name directly.
- Updated the `incr` method in the StatsD class to utilize the `get_name`
method for constructing metric names.
Please review the changes and provide feedback!
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
