bugraoz93 commented on code in PR #42959:
URL: https://github.com/apache/airflow/pull/42959#discussion_r1798254371
##########
airflow/api_fastapi/views/public/dags.py:
##########
@@ -92,6 +93,28 @@ async def get_dags(
)
+@dags_router.get(
+ "/tags",
+ response_model=list[DAGTagResponse],
Review Comment:
I think this is not needed. ResponseModels are already automatically
generated in FastAPI and cascaded to openapi spec as well.
I think rather than adding this here, we should create a pydantic model for
this response and retrun according to the new model.
Similar to this
[DAGCollectionResponse](https://github.com/apache/airflow/blob/b92c66d45d206c670516f192662bfcf8ad34bec8/airflow/api_fastapi/serializers/dags.py#L103)
model but without `total_entries` of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
