romsharon98 commented on code in PR #42835:
URL: https://github.com/apache/airflow/pull/42835#discussion_r1798181484
##########
airflow/providers/apache/spark/hooks/spark_sql.py:
##########
@@ -143,8 +143,13 @@ def _prepare_command(self, cmd: str | list[str]) ->
list[str]:
"""
connection_cmd = ["spark-sql"]
if self._conf:
- for conf_el in self._conf.split(","):
- connection_cmd += ["--conf", conf_el]
+ conf = self._conf
+ if isinstance(conf, dict):
+ for key in conf:
+ connection_cmd += ["--conf", f"{key}={conf[key]}"]
Review Comment:
```suggestion
for key, value in conf.items():
connection_cmd += ["--conf", f"{key}={value}"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
