kbendick commented on code in PR #23704:
URL: https://github.com/apache/airflow/pull/23704#discussion_r874048450


##########
docs/apache-airflow-providers-tabular/connections.rst:
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+.. _howto/connection:tabular:
+
+Tabular Connection
+==================
+
+The Tabular connection type enables connection to Tabular to request a short 
lived token to access the Apache Iceberg tables. This token can be injected as 
an environment variable, to be used with Trino, Spark, Flink or your favorite 
query engine that supports Apache Iceberg.
+
+Default Connection IDs
+----------------------
+
+Tabular Hook uses the parameter ``tabular_conn_id`` for Connection IDs and the 
value of the parameter as ``tabular_default`` by default. You can create 
multiple connections in case you want to switch between environments.
+
+Configuring the Connection
+--------------------------
+Client ID
+    The Client ID from Tabular
+
+Client Secret
+    The Client Secret from Tabular
+
+Extra (optional, connection parameters)
+    Specify the extra parameters (as json dictionary) that can be used in 
Trino connection. The following parameters out of the standard python 
parameters are supported:

Review Comment:
   Nit: Is this supposed to say `Trino` connection or `Tabular` connection? I 
don't believe there's anything Trino specific about these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to