potiuk commented on PR #23286: URL: https://github.com/apache/airflow/pull/23286#issuecomment-1122478305
Hmm. One more **problem** I see with it (and maybe to concur with the original question of @uranusjr ) - where do you think this method might be used? In Providers or somewhere in the core? Because if someone will use the method in providers (and this seems like a likely thing to do), then the change is not backwards compatible for Airlfow 2.1+ - and our providers should support 2.1+ for now (and 2.2 till the end of year). So it's a bit problematic change for compatibilty - especially that it will not be caught by our "import" check. What I would suggest instead, if we really want to add it is to leave the original method and add a new method passing all params. This will be safer and our import check with providers will catch it, because the method will be missing in Airflow 2.1 and Airflow 2.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
