ashb commented on code in PR #23290:
URL: https://github.com/apache/airflow/pull/23290#discussion_r861694666
##########
airflow/www/static/js/tree/dagRuns/index.test.jsx:
##########
@@ -42,13 +42,13 @@ const Wrapper = ({ children }) => {
<ContainerRefProvider value={{}}>
<TimezoneProvider value={{ timezone: 'UTC' }}>
<AutoRefreshProvider value={{ isRefreshOn: false, stopRefresh:
() => {} }}>
- <SelectionProvider value={{ onSelect: () => {}, selected: {}
}}>
+ <MemoryRouter>
Review Comment:
Why do we use MemoryRouter here but BrowserRouter elsewhere?
Does MemoryRouter mean that components here don't change the URL, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
