potiuk commented on a change in pull request #22595:
URL: https://github.com/apache/airflow/pull/22595#discussion_r837764876
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_manager.py
##########
@@ -214,9 +214,13 @@ def consume_logs(*, since_time: Optional[DateTime] = None,
follow: bool = True)
for line in logs:
timestamp, message =
self.parse_log_line(line.decode('utf-8'))
self.log.info(message)
- except BaseHTTPError: # Catches errors like
ProtocolError(TimeoutError).
+ except BaseHTTPError:
self.log.warning(
- 'Failed to read logs for pod %s',
+ "Reading of logs was interrupted, likely due to a
connection issue. "
+ "Will retry momentarily.",
Review comment:
Should we at least add the error message - not traceback - here in
parenthesis (without it, It feels completely blind guessing).
I think that would strike the right balance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
