potiuk commented on pull request #21776: URL: https://github.com/apache/airflow/pull/21776#issuecomment-1049935021
I do not think we should do it this way @jedcunningham @kaxil ? ArgoCD is only one way of deploying the chart and I believe, if it is possibl, we should rather modify chart documentation with "Deploy Chart with ArgoCD" and even provide an example how to add custom argo annoations (and flag to disable the built-in hooks). As far as I understand (or maybe I am wrong0 - the ArgoCD labels could be added via: ``` .Values.migrateDatabaseJob.jobAnnotations ``` So this is like three lines to add to custom values.yml ? Am I wrong @druizz90 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
