Bowrna commented on a change in pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#discussion_r810230692
##########
File path: dev/breeze/src/airflow_breeze/ci/build_image.py
##########
@@ -83,11 +83,17 @@ def construct_docker_command(ci_image: BuildParams) ->
List[str]:
def build_image(verbose, **kwargs):
ci_image_params = BuildParams(**filter_out_none(**kwargs))
+ ci_image_cache_dir = Path(BUILD_CACHE_DIR, ci_image_params.airflow_branch)
+ ci_image_cache_dir.mkdir(parents=True, exist_ok=True)
+ touch_cache_file(
+ f"built_{ci_image_params.python_version}",
+ root_dir=ci_image_cache_dir,
+ )
is_cached, value = check_cache_and_write_if_not_cached(
"PYTHON_MAJOR_MINOR_VERSION", ci_image_params.python_version
)
if is_cached:
ci_image_params.python_version = value
cmd = construct_docker_command(ci_image_params)
- output = run_command(cmd, verbose=verbose, text=True)
+ output = run_command(cmd, verbose=verbose, cwd=AIRFLOW_SOURCE, text=True)
Review comment:
@potiuk Changes done for CWD in subprocess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
