potiuk commented on a change in pull request #21646:
URL: https://github.com/apache/airflow/pull/21646#discussion_r809485527
##########
File path: docs/apache-airflow/dag-run.rst
##########
@@ -111,7 +111,9 @@ in the configuration file. When turned off, the scheduler
creates a DAG run only
"""
from airflow.models.dag import DAG
from airflow.operators.bash import BashOperator
- from datetime import datetime, timedelta
+
+ # Note that if you plan to use timezones you should use pendulum
+ from pendulum import datetime, timedelta
Review comment:
I don't think in this case we need ot to do it. The thing here is to
make the "datetime" pendulum, so that whenever you want to add timezone (for
example because you realise you need it after the fact), you are not tempted to
use timezone from stdlib - because it causes problems. For example however it
would likely be good to separate it visibly at least
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
