eladkal commented on a change in pull request #21504:
URL: https://github.com/apache/airflow/pull/21504#discussion_r804247073
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -556,7 +556,9 @@ def check_for_partition(self, schema: str, table: str,
partition: str) -> bool:
True
"""
with self.metastore as client:
- partitions = client.get_partitions_by_filter(schema, table,
partition, 1)
+ partitions = client.get_partitions_by_filter(
+ schema, table, partition, HiveMetastoreHook.MAX_PART_COUNT
Review comment:
Is this a breaking change?
is 1 is not desirable in all cases? (if there are valid use cases for 1 then
maybe we should make the 4th parameter (limit) configurable thus allowing each
user to set whatever value he wishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
